Skip to content

Fix deprecation warnings, report them in tests #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 3, 2025
Merged

Fix deprecation warnings, report them in tests #280

merged 3 commits into from
Nov 3, 2025

Conversation

@JanJakes
Copy link
Member

@JanJakes JanJakes commented Oct 31, 2025 •
edited
Loading

It turns out that E_DEPRECATED was excluded in the test bootstrap.

When enabling it, I found a few small issues, plus fixed this one:

PHP Deprecated:  strtolower():
Passing null to parameter #1 ($string) of type string is deprecated
in .../sqlite-database-integration/wp-includes/sqlite-ast/class-wp-sqlite-driver.php on line 2868

This deprecation warning occurs on PHP >= 8.4 when a SQL variable with a null value is read.

@JanJakes JanJakes force-pushed the fix-deprecation-warning branch from fe4a96f to c333f97 Compare October 31, 2025 10:18
@JanJakes JanJakes force-pushed the fix-deprecation-warning branch from c333f97 to 573a651 Compare October 31, 2025 13:55
@JanJakes JanJakes changed the title Fix "strtolower(): Passing null to parameter #1 ($string) of type string is deprecated" Fix deprecation warnings, report them in tests Oct 31, 2025
@JanJakes JanJakes force-pushed the fix-deprecation-warning branch from 573a651 to 550e756 Compare October 31, 2025 14:00
@JanJakes JanJakes force-pushed the fix-deprecation-warning branch from 550e756 to 3485241 Compare October 31, 2025 14:08
@JanJakes JanJakes requested a review from adamziel October 31, 2025 14:20
@JanJakes JanJakes merged commit d7c3309 into develop Nov 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamziel adamziel adamziel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JanJakes @adamziel